This repository has been archived by the owner on Nov 3, 2021. It is now read-only.
Replace use of asExternalTypedData with asTypedList. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkustermann
approved these changes
Oct 15, 2019
devoncarew
reviewed
Oct 15, 2019
| @@ -1,3 +1,11 @@ | |||
| # 0.3.1-dev.2 | |||
|
|
|||
| * Replaced uses of deprecated `asExternalTypedData` with `asTypedList`. | |||
There was a problem hiding this comment.
Does this change the min. Dart SDK requirements for this package? If so, we should update the pubspec as well.
There was a problem hiding this comment.
I don't think asTypedList has been published in a dev release yet, but we needed to make the change to ship D26, since this package is used in the SDK and we want to remove deprecated methods before shipping.
After shipping we should update the minimum constraint to D26 /cc @dcharkes @mkustermann
truongsinh
added a commit
to truongsinh/tflite_native
that referenced
this pull request
Nov 13, 2019
* master: Update landed PR with new API (dart-archive#32) Resize tensor (dart-archive#24) Replace use of asExternalTypedData with asTypedList. (dart-archive#31) Remove type argument from structs (dart-archive#30) Remove use of deprecated FFI features via package:ffi. (dart-archive#29) Enable ci testing on osx (dart-archive#27) Whitespace cleanup in .travis.yml and README.md Enable and fix a number of lints significantly improve performance by `asExternalTypedData` (dart-archive#23) v0.3.0 Issue 18 - Update to latest tflite C API (dart-archive#21) Update README.md Use Dart 2.5.0 as oldest required pub version (dart-archive#20) # Conflicts: # lib/src/bindings/model.dart # lib/src/interpreter.dart # lib/src/model.dart # lib/src/tensor.dart # test/tflite_test.dart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.