Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Update AUTHORS #1

Merged
merged 1 commit into from
Apr 21, 2015
Merged

Update AUTHORS #1

merged 1 commit into from
Apr 21, 2015

Conversation

devoncarew
Copy link
Contributor

Update the AUTHORS file; only people outside Google need to be added to the authors file.

@scheglov

Update the AUTHORS file
scheglov added a commit that referenced this pull request Apr 21, 2015
@scheglov scheglov merged commit 70dd146 into master Apr 21, 2015
@scheglov
Copy link
Contributor

Thank you!
Merged.

Is it what I should do?
Or should I LGTM it and allow you to merge?

@devoncarew
Copy link
Contributor Author

It's a trivial change :) Either works.

Generally (since I can commit), lgtm, then I'll merge. For people who can't commit, lgtm then you merge.

@scheglov
Copy link
Contributor

OK, got it.

Should the branch be deleted?
Will you? :-)

@devoncarew
Copy link
Contributor Author

I can do it. I there were tests running on a bot (and the PR was being tested), you'd want to wait until the tests had finished.

@devoncarew devoncarew deleted the devoncarew-patch-1 branch April 21, 2015 04:25
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants