Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Remove an unnecessary test expectation #42

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Conversation

natebosch
Copy link
Contributor

This expect is testing language implementation which is not necessary to
do in this package.

This expect is testing language implementation which is not necessary to
do in this package.
@sigmundch
Copy link
Contributor

This expect is testing language implementation which is not necessary to
do in this package.

Not sure I follow what are you referring to as "a language implementation" here? Maybe the intention here was to test that the source-map parseJson throws when the input is not a simple mapping, but that you need parseJsonExtended to handle that instead?

@sigmundch
Copy link
Contributor

Ah, never mind, back in the day parseJson might have accepted any input and not just Maps.... now that it only accepts Maps I can see how this is unnecessary.

@natebosch natebosch merged commit 49a061e into master Feb 11, 2020
@natebosch natebosch deleted the unnecessary-type-test branch February 11, 2020 19:26
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
This expect is testing language implementation which is not necessary to
do in this package.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants