Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Remove upper case constants #27

Merged
merged 6 commits into from
May 25, 2018

Conversation

lrhn
Copy link
Contributor

@lrhn lrhn commented Apr 11, 2018

No description provided.

@lrhn lrhn requested a review from kevmoo May 4, 2018 10:17
@kevmoo kevmoo requested review from nex3 and removed request for kevmoo May 4, 2018 16:04
CHANGELOG.md Outdated
* Implement `highlight` in `SourceMapFileSpan`.
* Require version `^1.3.0` of `source_span`.
* Implement `highlight` in `SourceMapFileSpan`.
* Require version `^1.3.0` of `source_span`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was a space added here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with entries below.
Not that those are consistent anyway, if you go further down, so I'll just remove the spaces again.

@lrhn
Copy link
Contributor Author

lrhn commented May 23, 2018

PTAnotherL

@lrhn lrhn merged commit dacf181 into dart-archive:master May 25, 2018
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
* Remove usage of upper-case constants.

* update SDK version
* remove stable from Travis config
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants