This repository was archived by the owner on Jan 14, 2025. It is now read-only.
Fix analyzer warnings in parser_test.dart #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Dec 12, 2017
test/parser_test.dart
Outdated
| @@ -329,14 +329,14 @@ main() { | |||
| MAP_WITH_SOURCE_LOCATION, | |||
| MAP_WITH_SOURCE_LOCATION_AND_NAME | |||
| ]) { | |||
| var mapping = parseJson(expected); | |||
| var mapping = parseJson(expected) as SingleMapping; | |||
There was a problem hiding this comment.
nit: why not
SingleMapping mapping = parseJson(expected);
?
Then the second "as SingleMapping" can be removed.
jacob314
reviewed
Dec 12, 2017
test/parser_test.dart
Outdated
| expect(mapping.toJson(), equals(expected)); | ||
| } | ||
| // Invalid for this case | ||
| expect(() => parseJson(SOURCE_MAP_BUNDLE as dynamic), throws); | ||
| expect(() => parseJson(SOURCE_MAP_BUNDLE as dynamic), throws) as MappingBundle; |
There was a problem hiding this comment.
this line makes no sense. Does this even compile?
There was a problem hiding this comment.
Sorry, copy+paste error. Should have added to the next line...
jacob314
approved these changes
Dec 12, 2017
jacob314
approved these changes
Dec 12, 2017
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 10, 2024
…rgan-patch-1 Fix analyzer warnings in parser_test.dart
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.