This repository was archived by the owner on Jan 14, 2025. It is now read-only.
fixes #16 #17
Merged
fixes #16 #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -77,7 +77,8 @@ class Entry implements Comparable { | |||
| /// location in the target file. We sort primarily by the target offset | |||
| /// because source map files are encoded by printing each mapping in order as | |||
| /// they appear in the target file. | |||
| int compareTo(Entry other) { | |||
| int compareTo(_other) { | |||
There was a problem hiding this comment.
Make Entry implement Comparable<Entry> instead?
There was a problem hiding this comment.
Also: we don't use _understore names as parameters.
|
CC @nex3 |
|
I'm not a maintainer for this package. |
|
CC @sigmundch ? |
|
lgtm, thank for the fix! |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 10, 2024
…mode_fix fixes dart-lang/source_maps#16
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.