Skip to content
This repository has been archived by the owner on Oct 23, 2024. It is now read-only.

Make accept a generic method #21

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Make accept a generic method #21

merged 2 commits into from
Dec 18, 2019

Conversation

natebosch
Copy link
Contributor

Stop throwing away types from the Visitor which already has a generic.

@natebosch
Make accept a generic method
7fde86d 
Stop throwing away types from the `Visitor` which already has a generic.
@natebosch natebosch requested a review from jakemac53 December 18, 2019 22:05
jakemac53
jakemac53 reviewed Dec 18, 2019
View reviewed changes
Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be breaking if something was relying on dynamic dispatch?

Not sure if this is a public API or not.

@natebosch
Copy link
Contributor Author

This is not a public API.

@natebosch natebosch merged commit 8c4c0f8 into master Dec 18, 2019
@natebosch natebosch deleted the accept-dynamic branch December 18, 2019 22:29
mosuem pushed a commit to dart-lang/tools that referenced this pull request Oct 18, 2024
@natebosch
Make accept a generic method (dart-archive/boolean_selector#21)
9fdf08e 
Stop throwing away types from the `Visitor` which already has a generic.

Use generic for RecursiveVisitor instead of allowing an implicit `dynamic`.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakemac53 jakemac53 jakemac53 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natebosch @jakemac53 @googlebot