Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

[WIP] Introduction of @NgTemplate #861

Closed
wants to merge 5 commits into from
Closed

[WIP] Introduction of @NgTemplate #861

wants to merge 5 commits into from

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Apr 4, 2014

very early preview...
I will work on this on next week.

@vicb vicb added cla: yes and removed cla: no labels Apr 4, 2014
@vicb vicb changed the title [WIP] intorduction of @NgTemplate [WIP] introduction of @NgTemplate Apr 7, 2014
@vicb vicb changed the title [WIP] introduction of @NgTemplate Introduction of @NgTemplate Apr 8, 2014
@vicb
Copy link
Contributor Author

vicb commented Apr 8, 2014

This PR should be ready for review. (Most interesting changes are in the second commit)

There are still a couple of todos:

  • handle registry,
  • rebase on latest master,
  • add some docs here and there,
  • discuss the namings:
    • NgAttrAnnotation: parent class for annotations with a map
    • NgPlainTemplate: The former NgTemplate (directive) - rename to avoid collision with the new @NgTemplate

@mhevery @jbdeboer I would appreciate your feedback when you have time to review this

@mhevery
Copy link
Contributor

mhevery commented Apr 10, 2014

I wanted to play with this code but it does not apply cleanly to latests master. Please rebase.

@vicb
Copy link
Contributor Author

vicb commented Apr 14, 2014

@mhevery I've just rebased if you still feel like playing.

TODOs are still to do. I'll tackle them tomorrow morning.

Hum... and I think there was some more feedback from you in this PR earlier today. Have you deleted your comment ?

vicb added 5 commits April 15, 2014 10:37
@vicb
style: code cleanup
a9ba4a3
@vicb
feat(NgTemplate): @NgTemplate replace @ngdirective(NgAnnotation.TRANS…
c7dcb8e 
…CLUDE_CHILDREN)

1- Transclusion syntax has changed:

Before:

    @ngdirective(
        children: NgAnnotation.TRANSCLUDE_CHILDREN,
        map: const {'.': 'expression'},
        <other kv pairs>)

After:

    @NgTemplate(
        mapping: 'expression',
        <olther kv pairs>)

2- NgAnnotation.children has been removed in facor of NgAnnotation.compileChildren

Before:

    children: NgAnnotation.COMPILE_CHILDREN
    children: NgAnnotation.IGNORE_CHILDREN
    children: NgAnnotation.TRANSCLUDE_CHILDREN

After:

    compileChildren: true
    compileChildren: false
    Use @NgTemplate (see the previous section)
@vicb
feat(DomCursor): add processChildNodes()
63f5b54
@vicb
refactor(Template): s/NgPlainTemplate/NgTemplateDirective/
8212d2d
@vicb
feat(NgTemplate): add support for @NgTemplate in registry_dynamic
4e9d295
@vicb
Copy link
Contributor Author

vicb commented Apr 15, 2014

@mhevery The only thing left is the transformer which I expect to push later today. Review can start for the committed code.

This was referenced Apr 15, 2014
Closed
Merged
Closed
@mhevery
Copy link
Contributor

mhevery commented Apr 18, 2014

rebase to master

@vicb
Copy link
Contributor Author

vicb commented Apr 21, 2014

I'll rebase & address the feedback once #926 is in so that I can update the metadata extractor.

@vicb
Copy link
Contributor Author

vicb commented Apr 21, 2014

#926 is in, I'll take care of this over the next few days (after 914, 917 & 919)

@mhevery
Copy link
Contributor

mhevery commented Apr 22, 2014

Ok merge when ready.

@vicb vicb changed the title Introduction of @NgTemplate [WIP] Introduction of @NgTemplate Apr 24, 2014
@vicb vicb mentioned this pull request May 5, 2014
Closed
2 tasks
@vicb
Copy link
Contributor Author

vicb commented May 5, 2014

closed in favor of #1003.
I'll reopen the minor items in different PRs.

@vicb vicb closed this May 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @mhevery