This repository has been archived by the owner on Feb 22, 2018. It is now read-only.
feature(directive_injector): add View to DirectiveInjector #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mhevery could you review it? |
vsavkin
added a commit
that referenced
this pull request
Aug 8, 2014
Some directives require access to the current view. Add the view field to the DirectiveInjector class, so it can be injected. Closes #1293
vsavkin
added a commit
that referenced
this pull request
Aug 8, 2014
Some directives require access to the current view. Add the view field to the DirectiveInjector class, so it can be injected. Closes #1293
|
Please rebase and get the tests passing. |
vsavkin
force-pushed
the
add_view_property_to_all_directive_injectors
branch
from
b3c2017 to
aa1fcfd
Compare
|
@jbdeboer rebased on top of master |
3 tasks
vsavkin
force-pushed
the
add_view_property_to_all_directive_injectors
branch
from
aa1fcfd to
95a7e3c
Compare
Some directives require access to the current view. Add the view field to the DirectiveInjector class, so it can be injected.
vsavkin
force-pushed
the
add_view_property_to_all_directive_injectors
branch
from
95a7e3c to
426e651
Compare
|
Closed by f5bc41a |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some directives require access to the current view. Add the view field to the DirectiveInjector class, so it can be injected.