Skip to content
This repository has been archived by the owner on Feb 22, 2018. It is now read-only.

For performance, use Injector.getByKey instead of Injector.get #1081

Closed
jbdeboer opened this issue May 28, 2014 · 4 comments · Fixed by #1100
Closed

For performance, use Injector.getByKey instead of Injector.get #1081

jbdeboer opened this issue May 28, 2014 · 4 comments · Fixed by #1100

Comments

@jbdeboer
Copy link
Contributor

This avoids a hash lookup on get
@jbdeboer
Copy link
Contributor Author

@markovuksanovic Could you take a look at these injector.get calls? They should all be replaced with a injector.getByKey call where the key parameter is static.

Right now we are looking up the key in a cache inside of di.Key, but this is wasted work if we can simply pass in a static Key.

@jbdeboer
Copy link
Contributor Author

I am working on element_binder.dart

jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue May 29, 2014
@jbdeboer
perf(view factory): Compute DI Keys ahead of time
9e9e6e8 
4% improvement in TreeComponent benchmark

For dart-archive#1081
@jbdeboer jbdeboer mentioned this issue May 29, 2014
Closed
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue May 29, 2014
@jbdeboer
perf(view factory): Compute DI Keys ahead of time
3a44d67 
4% improvement in TreeComponent benchmark

For dart-archive#1081
@mvuksano
Copy link
Contributor

@jbdeboer I guess that means I should exclude element_binder when working on this?

@jbdeboer
Copy link
Contributor Author

:-)

On Thu, May 29, 2014 at 6:48 PM, Marko Vuksanovic [email protected]
wrote:

@jbdeboer https://github.com/jbdeboer I guess that means I should
exclude element_binder when working on this?

—
Reply to this email directly or view it on GitHub
#1081 (comment)
.

jbdeboer added a commit that referenced this issue May 30, 2014
@jbdeboer
perf(view factory): Compute DI Keys ahead of time
9277283 
4% improvement in TreeComponent benchmark

For #1081

Closes #1085
jbdeboer added a commit that referenced this issue May 30, 2014
@jbdeboer
perf(view factory): Compute DI Keys ahead of time
317c23c 
4% improvement in TreeComponent benchmark

For #1081

Closes #1085
jbdeboer added a commit to jbdeboer/angular.dart that referenced this issue Jun 2, 2014
@jbdeboer
perf(view factory): Compute DI Keys ahead of time
4b74df2 
4% improvement in TreeComponent benchmark

For dart-archive#1081

Closes dart-archive#1085
jbdeboer added a commit that referenced this issue Jun 3, 2014
@jbdeboer @chirayuk
perf(view factory): Compute DI Keys ahead of time
22d3248 
4% improvement in TreeComponent benchmark

For #1081

Closes #1085
mvuksano added a commit to mvuksano/angular.dart that referenced this issue Jun 3, 2014
@mvuksano
perf: Use precomputed keys with injector for performance reasons.
35f64cb 
Closes dart-archive#1081
@mvuksano mvuksano mentioned this issue Jun 3, 2014
Merged
mvuksano added a commit to mvuksano/angular.dart that referenced this issue Jun 4, 2014
@mvuksano
perf: Use precomputed keys with injector for performance reasons.
0835db7 
Closes dart-archive#1081
jbdeboer pushed a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@mvuksano @jbdeboer
perf: Use precomputed keys with injector for performance reasons.
e8a360b 
Closes dart-archive#1081
jbdeboer pushed a commit to jbdeboer/angular.dart that referenced this issue Jun 4, 2014
@mvuksano @jbdeboer
perf: Use precomputed keys with injector for performance reasons.
129d849 
Closes dart-archive#1081
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
perf(view factory): Compute DI Keys ahead of time
4823b57 
4% improvement in TreeComponent benchmark

For dart-archive#1081

Closes dart-archive#1085
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@mvuksano
perf: Use precomputed keys with injector for performance reasons.
db26877 
Closes dart-archive#1081
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@jbdeboer
perf(view factory): Compute DI Keys ahead of time
391aa48 
4% improvement in TreeComponent benchmark

For dart-archive#1081

Closes dart-archive#1085
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
@mvuksano
perf: Use precomputed keys with injector for performance reasons.
149086a 
Closes dart-archive#1081
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: Use precomputed keys with injector for performance reasons. mvuksano/angular.dart
2 participants
@mvuksano @jbdeboer