-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xresources-based theme #35
Conversation
src/posting/app.py
Outdated
@@ -701,6 +702,52 @@ def on_mount(self) -> None: | |||
) | |||
self.theme_change_signal = Signal[ColorSystem](self, "theme-changed") | |||
self.theme = self.settings.theme | |||
self.try_to_add_xresources_theme() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd want to put this behind a config option use_xresources
which is False
by default. If that option is True
, then this method would be called.
It should also be possible to set the theme to xresources-dark
or xresources-light
directly from the config file (e.g. theme: xresource-dark
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like this to sit behind a config option.
Thanks for the contribution! - I've done a short review, let me know what you think or if you need help. |
Done. I've:
|
Oops, my Emacs has auto-formatted the table in the README. I hope you don't mind. |
Thanks! I'll try to review this this week. |
Thank you - I've made a few minor changes. Moved stuff into a new module to keep it separate from the Would you mind giving it a quick test? If it looks good to you I will merge. |
Thanks. But the current version fails with:
The point of |
I use Xresources to configure themes. This PR adds themes called
xresources-light
andxresources-dark
, provided thatxrdb
is found andxrdb -query
returns the necessary colors.This is a bit suboptimal for light theme (which I use), because light themes don't need as much shading as C-o and C-p currently do. But
solarized-light
also has this issue.