use_tidy_github_actions()
#171
Conversation
Use the latest versions of r-lib actions, and flesh out a more complete R version matrix.
|
@daroczig I can't figure out why this is failing on mac. The error occurs in this block: log_formatter(formatter_pander)
log_info(head(iris))And it seems like it's because it's using |
|
I figured it out! I'm not sure why it only failed on mac, but the problem was that the loggers from previously rendered vignettes were still active, so once I implemented a more thorough reset, the problem went away 🥳 |
| } | ||
| message | ||
|
|
||
| withCallingHandlers( |
There was a problem hiding this comment.
This was previously incorrectly vectorised, leading to a bunch of duplication. I fixed the problem and added a test.
| @@ -1,7 +1,12 @@ | |||
| ## init storage for all logger settings | |||
| namespaces <- new.env() | |||
| namespaces <- new.env(parent = emptyenv()) | |||
There was a problem hiding this comment.
I don't think this changes behaviour, but it's good practice.
| @@ -4,6 +4,7 @@ | |||
| #' @export | |||
| #' @importFrom logger log_level | |||
| logger_tester_function <- function(level, msg) { | |||
| set.seed(1014) | |||
There was a problem hiding this comment.
This makes the output reproducible for use in snapshot tests.
| '|||||') | ||
| local_test_logger(layout = layout_glue_generator("{level} {msg}")) | ||
|
|
||
| expect_snapshot({ |
There was a problem hiding this comment.
I think snapshots do a better job of capturing the intent here (I'm sure they didn't exist when this code was written), and since it doesn't seem to need to be run in a separate process.
| expect_match(eval_outside('system("echo 42", invisible = TRUE)'), 'INFO') | ||
| } | ||
| expect_snapshot({ | ||
| writeLines(eval_outside("log_messages()", 'message(42)')) |
There was a problem hiding this comment.
Similarly I moved all these to snapshot tests, which makes it easier to see what's going wrong if there are failures.
| 'logger.tester / logger.tester / logger.tester / logger_info_tester_function / logger_info_tester_function("foobar")') | ||
| unlink(t) | ||
| test_that('log_info() captures local info', { | ||
| local_test_logger( |
There was a problem hiding this comment.
Again, not sure why this was running in separate process, but the snapshot outputs from the active process look fine to me.
There was a problem hiding this comment.
it's been a long time ago 🤐 but if I recall correctly, I had some issues with testthat injecting frames in the call stack ... but happy to hear it's working 🎉
| @@ -89,17 +82,13 @@ Putting all these together (by explicitly setting the default config in the `glo | |||
| log_threshold(INFO) | |||
| log_formatter(formatter_glue) | |||
| log_layout(layout_simple) | |||
| log_appender(appender_console) | |||
| log_appender(appender_stdout) | |||
There was a problem hiding this comment.
This was causing log output to be lost since knitr doesn't (and IMO shouldn't) capture stderr.
Use the latest versions of r-lib actions, and flesh out a more complete R version matrix.