Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include log_level args explicitly in log_* wrappers #143

Merged
merged 5 commits into from
Mar 3, 2024

Conversation

MichaelChirico
Copy link
Contributor

@MichaelChirico MichaelChirico commented Feb 29, 2024

Closes #140

NEWS is left out for now as I'm not sure whether to classify this change as a 'fix' or a 'feature'.

@daroczig daroczig mentioned this pull request Feb 29, 2024
4 tasks
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.95%. Comparing base (ec619ce) to head (10e59d7).
Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #143   +/-   ##
=======================================
  Coverage   83.95%   83.95%           
=======================================
  Files          10       10           
  Lines         561      561           
=======================================
  Hits          471      471           
  Misses         90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daroczig
Copy link
Owner

Thanks for your work on this 🙇
Yeah, this looks great. There was a minor issue, but after the above commits, all tests passed.
Planning to merge by the end of the week -- if you can think of any good test examples, I'd highly appreciate that. I will go though the NEWS file as quote a few tickets have been resolved today, but if you can add your contributions, that would be great as well.

@MichaelChirico
Copy link
Contributor Author

Added one simple test, PTAL.

For the NEWS, I will leave it to you how you want to organize the entry -- not sure if it's a fix or a feature in this case.

@daroczig daroczig merged commit 5b3b117 into daroczig:master Mar 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.topenv cannot be supplied to log_info()
2 participants