-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/26 return char #133
Add/26 return char #133
Conversation
@r2evans I've refactored a bit, but hopefully this is in line with the expectations/use-case -- please let me know. In short, instead of creating an If you might have time to experiment with it over the weekend, that would be great, as I'm planning to release to CRAN soon (I promised that after a few nudges in other threads). No hard feelings if you don't get there -- my bad I've been sitting on this for so long. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 83.95% 84.22% +0.27%
==========================================
Files 10 10
Lines 561 577 +16
==========================================
+ Hits 471 486 +15
- Misses 90 91 +1 ☔ View full report in Codecov by Sentry. |
Not this weekend, but I'll take a look later. Thanks! |
Thanks a ton! 🙇 I'm going to merge this for now, but we can revisit later anytime -- so please do post your findings when you have a chance. |
No description provided.