Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/26 return char #133

Merged
merged 6 commits into from
Mar 3, 2024
Merged

Add/26 return char #133

merged 6 commits into from
Mar 3, 2024

Conversation

r2evans
Copy link

@r2evans r2evans commented Nov 20, 2023

No description provided.

@daroczig daroczig mentioned this pull request Feb 29, 2024
4 tasks
@daroczig
Copy link
Owner

daroczig commented Mar 1, 2024

@r2evans I've refactored a bit, but hopefully this is in line with the expectations/use-case -- please let me know. In short, instead of creating an as.character fn, the log fns now return both the formatted log messages and the (layouted) record, so the user can pick either via the list elements.

If you might have time to experiment with it over the weekend, that would be great, as I'm planning to release to CRAN soon (I promised that after a few nudges in other threads). No hard feelings if you don't get there -- my bad I've been sitting on this for so long.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 84.22%. Comparing base (d35a254) to head (c0578d8).

Files Patch % Lines
R/logger.R 96.15% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   83.95%   84.22%   +0.27%     
==========================================
  Files          10       10              
  Lines         561      577      +16     
==========================================
+ Hits          471      486      +15     
- Misses         90       91       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r2evans
Copy link
Author

r2evans commented Mar 1, 2024

Not this weekend, but I'll take a look later. Thanks!

@daroczig
Copy link
Owner

daroczig commented Mar 3, 2024

Thanks a ton! 🙇

I'm going to merge this for now, but we can revisit later anytime -- so please do post your findings when you have a chance.

@daroczig daroczig merged commit e550418 into daroczig:master Mar 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants