Evaluate arguments only if they are to be logged

daroczig · Jul 23, 2019 · 77afd3f · 77afd3f
1 parent f9bff45
commit 77afd3f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/R/logger.R b/R/logger.R
@@ -276,7 +276,7 @@ log_level <- function(level, ..., namespace = NA_character_,
     for (definition in definitions) {
 
         log_fun <- do.call(logger, definition)
-        log_arg <- list(...)
+        log_arg <- list()
 
         log_arg$level <- validate_log_level(level)
         log_arg$.logcall <- .logcall
@@ -290,7 +290,9 @@ log_level <- function(level, ..., namespace = NA_character_,
         log_arg$namespace <- namespace
 
         ## TODO try with match.call and replace [[1]]?
-        do.call(log_fun, log_arg)
+        if (log_arg$level <= get("threshold", envir = environment(log_fun))) {
+          do.call(log_fun, c(list(...), log_arg))
+        }
 
     }
 }