[imageio] Remove unnecessary loaders from fallback path #18498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These loaders will be called when the corresponding format signature is recognized. The signatures of these files are unambiguous and match all possible variations of the format, so the corresponding loaders in the fallback path will never be used.
TurboGit
added
priority: low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work on streamlining and simplifying the file loading process started with #18483.
These loaders will be called when the corresponding format signature is recognized. The signatures of these files are unambiguous and match all possible variations of the format, so the corresponding loaders in the fallback path will never be used.
Regarding the RGBE format, theoretically there may be files created at the very dawn of the format, when the author of the format himself did not yet think about the need for a signature. But the probability that someone will need to read those really ancient files in darktable is almost zero. Still, the commit that removes this loader from the fallback path is made separate, to facilitate reverting.