Fix flash firing detection #18415
Fix flash firing detection #18415
Conversation
TurboGit
added
the
scope: DAM
|
The exiv2 strings are localized, I think this will not work in other languages than english.
|
|
Strange, on my side I do not have it translated:
For |
|
And I do not see those strings in |
|
When building the macOS installation package I explicitly copy the exiv2 translations to |
|
So I don't see how to solve this. The exiv2 strings may be translated or not and darktable has no way to check for possible translation has it has no idea about the strings in exiv2. |
|
I think this should be reverted, see #18424 |
I'd say I should find a better solution instead of reverting. Just reverting will put us back in the state with other errors in flash detection. The new issue is the result of the fact that I forgot when writing the detection function that the string from exiv2 can be empty. And that I tested on an insufficiently diverse set of images... :( Simply adding this check makes no sense, as a completely different solution is needed. Both my PR and the code before it are incorrect in a situation where strings from exiv2 change depending on the language. |
|
that exif tag is actually a number, so that raw value should be used instead of string, which is also an easier test: https://stackoverflow.com/questions/7076958/read-exif-and-determine-if-the-flash-has-fired |
|
@parafin Yes, I am testing this very method right now. This was exactly the solution I wrote about. |
|
The promised correct solution: #18437 |
"Yes" at the beginning of the string does not mean that the flash fired, but that the flash function is present (for example, there is a built-in flash or an external flash is connected). There is a string from exiv2 "Yes, did not fire" for which checking only the first letter gave a false detection of the flash firing.
Similarly, not only "Y" as the first letter indicates the flash firing, the string obtained from exiv2 can also begin with the word "Fired".
Also removed "n/a" as the content of the text variable that indicates "flash firing". In fact, we always know whether the flash fired or not, "n/a" is meaningless.