Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the RVL lists to process hosts in groups to avoid OOM killer with large RFC1918 class A address ranges. #201

Merged
merged 6 commits into from
Dec 9, 2021

Conversation

unixrox
Copy link
Contributor

@unixrox unixrox commented Dec 6, 2021

The Linux OOM killer will come into play for large address space (I.e., RFC 1918 Class A address space - 10.10.10.10/8) when using reverse look ups (PTR) on hosts with even 32GB's of RAM. Recon is everything to us at Truvantis, because you can't protect or defend yourself from what you don't know about, so this was something we had to address, especially when targeting all the internal things during comprehensive penetration tests and attack surface analysis. This patch appears to resolve this specific issue, utilizing a small memory footprint while returning identified data quicker, all without significant memory impact. Approval to release this has been granted as it benefits the entire community. We hope you find this beneficial and thank you for your contribution to our community.

Linux OOM killer will come into play for large RFC1918 class A address space (I.e., 10.10.10.10/8) when using reverse look ups (PTR) on hosts with even 32GB's of RAM, impacting Truvantis comprehensive penetration tests and attack surface analysis engagements. This is a problem as it reduces potential attack surface which should be leveraged during such engagements. This patch resolves the issue, utilizing a small memory footprint while returning identified data quicker. Approval to release this has been granted as it benefits the entire community.
Linux OOM killer will come into play for large RFC1918 class A address space (I.e., 10.10.10.10/8) when using reverse look ups (PTR) on hosts with even 32GB's of RAM, impacting Truvantis comprehensive penetration tests and attack surface analysis engagements. This is a problem as it reduces potential attack surface which should be leveraged during such engagements. This patch resolves the issue, utilizing a small memory footprint while returning identified data quicker. Approval to release this has been granted as it benefits the entire community.
@L1ghtn1ng
Copy link
Collaborator

Thanks for this, can you also please make the same changes in just the normal dnsrecon.py as well please as they are the same as the binary is used as part of the install when you do setup.py install

Linux OOM killer will come into play for large RFC1918 class A address space (I.e., 10.10.10.10/8) when using reverse look ups (PTR) on hosts with even 32GB's of RAM, impacting Truvantis comprehensive penetration tests and attack surface analysis engagements. This is a problem as it reduces potential attack surface which should be leveraged during such engagements. This patch resolves the issue, utilizing a small memory footprint while returning identified data quicker. Approval to release this has been granted as it benefits the entire community.
@unixrox
Copy link
Contributor Author

unixrox commented Dec 6, 2021

Ah! My bad. That makes sense.

@unixrox
Copy link
Contributor Author

unixrox commented Dec 7, 2021

Looks like some of the validation checks failed for some versions of python due to the missing space around the operator. I believe I also simply hacked my way around this problem by modifying the bin file, and mixing the bin and the python file, without regarding the difference between the bin file and the python file. Do you want me to pull this down again, modify only the specific sections, include the space around the operator and comment/commit?

Linux OOM killer will come into play for large RFC1918 class A address space (I.e., 10.10.10.10/8) when using reverse look ups (PTR) on hosts with even 32GB's of RAM, impacting Truvantis comprehensive penetration tests and attack surface analysis engagements. This is a problem as it reduces potential attack surface which should be leveraged during such engagements. This patch resolves the issue, utilizing a small memory footprint while returning identified data quicker. Approval to release this has been granted as it benefits the entire community.
Linux OOM killer will come into play for large RFC1918 class A address space (I.e., 10.10.10.10/8) when using reverse look ups (PTR) on hosts with even 32GB's of RAM, impacting Truvantis comprehensive penetration tests and attack surface analysis engagements. This is a problem as it reduces potential attack surface which should be leveraged during such engagements. This patch resolves the issue, utilizing a small memory footprint while returning identified data quicker. Approval to release this has been granted as it benefits the entire community.
@unixrox
Copy link
Contributor Author

unixrox commented Dec 7, 2021

I decided to pull down the file and make the specific changes I intended to make. There are differences between the bin and the python file, but they are not mine. Hopefully this helps. Let me know if you need anything else from me and thank you for what you do for the community!

@L1ghtn1ng
Copy link
Collaborator

Thank you for the kind words

@L1ghtn1ng L1ghtn1ng merged commit 8cc121a into darkoperator:master Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants