Fixing some small bugs #192
Merged
+20
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The request_timeout variable is used inside of the general_enum function, but the variable is not defined in that scope, so we pass it as a parameter
Bing is sometimes not coopearting with the default user-agent it seems, so a custom user-agent seems appropriate here. A timeout is also good practice as running into the timeout will allow dnsrecon to continue even this request fails.
With the timeout set for the enum requests, dnsrecon may continue running even if one of the services is temporarily down or not reachable. crt.sh sometimes takes longer to respond, so a higher 30 second timeout was chosen here.
Some variables may be None in some circumstances if something went wrong, these checks will prevent dnsrecon from crashing in those cases.
|
Thanks for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
when using DnsRecon on a lot of domains (~1500), a few instances have repeatedly crashed in some cases.
All issues occured with the current git-master state and we fixed them so that DnsRecon doesn't crash anymore.
The issues were mostly timeouts or variables that are not checked for null values, details are in the commit messages.
This PR is to give back so others can also benefit from our changes :)
Let me know if there are any questions.