New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share by email is not encoding Title component #14

Closed

riccardodivirgilio opened this issue Apr 27, 2015 · 0 comments

riccardodivirgilio commented Apr 27, 2015

line 167 of social-share-kit.js is not encoding url component, this is creating a bad link which cannot be clicked.

            url = 'mailto:?subject=' + title +

should be

            url = 'mailto:?subject=' + encodeURIComponent(title) +

The text was updated successfully, but these errors were encountered:

darklow closed this as completed in

darklow added a commit that referenced this issue


          URL encode email subject. Fixes #14

19c64d0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment