Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base template fix #333

Merged
merged 2 commits into from
Mar 13, 2015
Merged

Base template fix #333

merged 2 commits into from
Mar 13, 2015

Conversation

simpleigh
Copy link
Contributor

Hi Kaspars,

Thanks so much for your work on Django Suit.

I've spotted a tiny bug in the base.html admin template where the {% block %} / {% endblock %} and <span> / </span> elements don't quite nest correctly - they're currently as follows:

<span class="user-links">
{% block userlinks %}
    <!-- ... -->
  </span>
{% endblock %}

This makes it slightly trickier to override the block as it's harder to avoid creating invalid HTML. First commit fixes; second makes a tiny indentation tweak.

This isn't relevant to your bs3 branch which refactors this area of the template, but should apply cleanly to develop.

darklow added a commit that referenced this pull request Mar 13, 2015
Base template fix for incorrect closing tag near userlinks block
@darklow darklow merged commit 8146f44 into darklow:develop Mar 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants