Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore_modules option #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ignore_modules option #20

wants to merge 2 commits into from

Conversation

hmy3743
Copy link

@hmy3743 hmy3743 commented May 19, 2023

Add ignore_modules option like Mix.Tasks.Test.Coverage

Copy link
Owner

@dariodf dariodf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the very late review. I like the code, but have a suggestion on how to test it. I might take it on myself later this week.

test_coverage: [
tool: LcovEx,
ignore_paths: ["deps/"],
ignore_modules: [ExampleProject.ExampleIgnoreModule, ~r/.*ExampleIgnoreRegex.*/]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to do a separate test for the new feature, and in that one assert that the module is not in the coverage file (instead of testing the omission in the print).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants