Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vite): correct iframe blocking #88

Merged
merged 2 commits into from
Jul 12, 2023
Merged

fix(vite): correct iframe blocking #88

merged 2 commits into from
Jul 12, 2023

Conversation

darioferderber
Copy link
Collaborator

@darioferderber darioferderber commented Apr 20, 2023 •
edited by dargmuesli
Loading

📚 Description

Resolves #79

📝 Checklist

  • All commits follow the Conventional Commit format
  • The PR's title follows the Conventional Commit format

@darioferderber darioferderber changed the title fix(vite:blockIframe) fix: vite:blockIframe Apr 20, 2023
@dargmuesli dargmuesli self-requested a review April 24, 2023 03:55
@dargmuesli
Copy link
Owner

I will review this later this week :)

@dargmuesli
Copy link
Owner

I've edited your PR description to say "Resolves" which automatically closes the mentioned issue once this PR is merged 🙌

@dargmuesli dargmuesli force-pushed the fix/vite-blockIframe branch from cf9a87a to 273972a Compare July 12, 2023 16:19
@dargmuesli dargmuesli changed the title fix: vite:blockIframe fix(vite): correct iframe blocking Jul 12, 2023
@dargmuesli
Copy link
Owner

I rewrote the commit messages to follow the conventional commit format for the automated release to create a proper changelog entry. Thank you for raising this PR! 🙌

@dargmuesli dargmuesli merged commit 8ab8b7a into master Jul 12, 2023
@dargmuesli dargmuesli deleted the fix/vite-blockIframe branch July 12, 2023 16:33
dargmuesli pushed a commit that referenced this pull request Jul 12, 2023
@semantic-release-bot
chore(release): 6.1.1 [skip ci]
857a210 
## [6.1.1](6.1.0...6.1.1) (2023-07-12)

### Bug Fixes

* **vite:** support iframe blocking ([#88](#88)) ([8ab8b7a](8ab8b7a))
@dargmuesli
Copy link
Owner

🎉 This PR is included in version 6.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dargmuesli dargmuesli dargmuesli left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(vite): support iframe blocking
2 participants
@darioferderber @dargmuesli