Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show banner again once cookies are added or removed #27

Closed
2 tasks done
dargmuesli opened this issue Jan 17, 2023 · 2 comments · Fixed by #50
Closed
2 tasks done

feat: show banner again once cookies are added or removed #27

dargmuesli opened this issue Jan 17, 2023 · 2 comments · Fixed by #50
Labels
enhancement New feature or request help wanted Extra attention is needed released on @beta released

Comments

@dargmuesli
Copy link
Owner

dargmuesli commented Jan 17, 2023

Describe the feature

Once the list of configured cookies changes, the banner should be shown again.

Additional information

  • Would you be willing to help implement this feature?

Final checks

@dargmuesli dargmuesli added the enhancement New feature or request label Jan 17, 2023
@dargmuesli dargmuesli added the help wanted Extra attention is needed label Feb 10, 2023
@dargmuesli dargmuesli mentioned this issue Feb 13, 2023
2 tasks
@dargmuesli dargmuesli moved this to 🔖 Ready in dargmuesli Feb 23, 2023
dargmuesli pushed a commit that referenced this issue Feb 24, 2023
# [5.0.0-beta.5](5.0.0-beta.4...5.0.0-beta.5) (2023-02-24)

### Bug Fixes

* **cookie-control:** correct toggle interactivity ([a43583f](a43583f))

### Features

* **cookie:** shorten default cookie names ([7d2c856](7d2c856))
* **cookie:** split by `|` ([ff25117](ff25117))
* show banner again once cookies are added or removed ([bf03cbc](bf03cbc)), closes [#27](#27)
@dargmuesli
Copy link
Owner Author

🎉 This issue has been resolved in version 5.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dargmuesli dargmuesli moved this from 🔖 Ready to ✅ Done in dargmuesli Feb 24, 2023
dargmuesli pushed a commit that referenced this issue Feb 27, 2023
# [5.0.0](4.6.1...5.0.0) (2023-02-27)

### Bug Fixes

* **cookie-control:** correct toggle interactivity ([a43583f](a43583f))
* **playground:** resolve own package as development dependency ([2fbe156](2fbe156))
* **styles:** correct padding and gap ([bba6c16](bba6c16))

* feat(styles)!: use gap ([9be04f1](9be04f1))
* feat(ponyfill)!: disable by default and rename ([4a84f81](4a84f81))

### Features

* add wcag text ([4d00f7d](4d00f7d))
* **checkbox:** use button with interactive semantics ([80fcf05](80fcf05)), closes [#41](#41)
* **cookie:** allow to add links ([f91f889](f91f889)), closes [#26](#26)
* **cookie:** shorten default cookie names ([7d2c856](7d2c856))
* **cookie:** split by `|` ([ff25117](ff25117))
* **css:** add focus ring color ([d3a09b0](d3a09b0))
* show banner again once cookies are added or removed ([bf03cbc](bf03cbc)), closes [#27](#27)

### BREAKING CHANGES

* - change padding, margins and gap for display flex
* - rename module option `isCssPolyfillEnabled` to `isCssPonyfillEnabled`
- set module option `isCssPonyfillEnabled` default to `false`
@dargmuesli
Copy link
Owner Author

🎉 This issue has been resolved in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed released on @beta released
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant