Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code changes for pubsub using http request #527

Closed
wants to merge 109 commits into from
Closed

code changes for pubsub using http request #527

wants to merge 109 commits into from
+42 −16

Conversation

pravinpushkar
Copy link
Contributor

Signed-off-by: Pravin Pushkar [email protected]

Description

Code example for Java pubsub using Http request

Issue reference

We strive to have all PRs being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: NA

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • The quickstart code compiles correctly
  • You've tested new builds of the quickstart if you changed quickstart code
  • You've updated the quickstart's README if necessary
  • If you have changed the steps for a quickstart be sure that you have updated the automated validation accordingly. All of our quickstarts have annotations that allow them to be executed automatically as code. For more information see mechanical-markdown. For user guide with examples see Examples.

Amulya Varote and others added 30 commits October 26, 2021 12:13
First Commit
a1a8d49
Directory structure based on building blocks
a4a8002
Folder error fix
293ec1e
Removed Java project
7ad0a81
Added java EventService
7e7a44a
Added java OrderProcessingService
89bbc5a
Added java CheckoutService
8b32ee6
Some csharp changes and javascript project
3cad625
Changed for loop of event service in js
99b8502
Deleted order processing folder from php
5934b6b
Remove ignored files
442dcec
deleted additonal gitignore files
5a03970
Modified git ignore file
ddd89e2
Removing Event Service
ea70a7e
Added state management examples
09dd70e
Commands file edited
5bff98f
Modified code
4607819
Added secrets management examples
a10ce53
Added secrets management examples
f4369f3
pub Sub examples
624e1de
@amulyavarote
Added commands
e68f22a
@amulyavarote
Commands added
0837a69
@amulyavarote
Added commands
b18a6bf
@amulyavarote
Commands added
8488f91
@amulyavarote
Delete Commands.docx
1a5f7bf
@amulyavarote
Delete Commands.docx
5ceba66
@amulyavarote
Delete Commands.docx
90d862c
@amulyavarote
Delete Commands.docx
e7cb9bf
@amulyavarote
Used yaml file added
74ccf60
@amulyavarote
Edited commands
c02cebf
paulyuk and others added 15 commits February 7, 2022 10:58
@paulyuk
Consistent env vars and strings
db7570d
@paulyuk
Using official DAPR_HTTP_PORT
b58a6a5
@paulyuk
typo in comment
7604174
@paulyuk
Per @amulya fixing camelCase in orderId
79a2821
@paulyuk
matching camelCase for orderId json. tests Pass
6a3cc82
@greenie-msft
Merge pull request dapr#9 from paulyuk/paulyuk/quickstartfeedback
ced42ee 
Adding HTTP quickstarts for Python and .NET (C#)
@greenie-msft
Add http example for JavaScript pubsub
84236ae 
Signed-off-by: Nick Greenfield <[email protected]>
@greenie-msft
Remove whitespace
148f339 
Signed-off-by: Nick Greenfield <[email protected]>
@greenie-msft
create http and sdk directories for each language
bb4db92 
Signed-off-by: Nick Greenfield <[email protected]>
@greenie-msft
Move Readme and fix broken links
504cc15 
Signed-off-by: Nick Greenfield <[email protected]>
@greenie-msft
Merge pull request dapr#10 from amulyavarote/javascript_pubsub_http
58c84f6 
Add http example for JavaScript pubsub
@greenie-msft
Remove quickstarts that need to be redone
f9c2d9a 
Signed-off-by: Nick Greenfield <[email protected]>
@greenie-msft
Remove .vscode dir
1849350 
Signed-off-by: Nick Greenfield <[email protected]>
@greenie-msft
Merge pull request dapr#11 from amulyavarote/remove_older_quickstarts
76b0ffe 
Remove quickstarts that need to be redone
@pravinpushkar
code changes for pubsub using http request
62522ea 
Signed-off-by: Pravin Pushkar <[email protected]>
amulyavarote
amulyavarote reviewed Feb 9, 2022
View reviewed changes
pub_sub/java/http/README.md Outdated
3. Run the Python subscriber app with Dapr:

```bash
dapr run --app-port 3000 --app-id order-processor --components-path ../../../components -- java -jar target/OrderProcessingService-0.0.1-SNAPSHOT.jar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the --app-port consistent. We have 5001, 7001 in other two sdks. Let's decide on one port number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I am changing it to default port (8080) exposed by tomcat which is used by spring boot applications.
We can change it to some common value but IMO I do not see it as an issue. Let us decide on this.

@amulyavarote
Copy link
Contributor

@pravinpushkar Can you please remove .mvn files from the PR. We dont merge .mvn files.

@pravinpushkar
Copy link
Contributor Author

@pravinpushkar Can you please remove .mvn files from the PR. We dont merge .mvn files.

done

@pravinpushkar pravinpushkar force-pushed the feature/java_http_pubsub_quickstarts branch 2 times, most recently from 93d1663 to 11a2240 Compare February 10, 2022 11:06
@pravinpushkar pravinpushkar force-pushed the feature/java_http_pubsub_quickstarts branch from 11a2240 to 5a6b909 Compare February 10, 2022 13:06
paulyuk
paulyuk requested changes Feb 13, 2022
View reviewed changes
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thank you. I have just a few small consistency and other items for you here.

pub_sub/java/http/order-processor/src/main/java/com/service/model/SubscriptionData.java

@Getter
@Setter
public class SubscriptionData<T> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Unpacks a CloudEvent. Consider adding comments like C# version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have provided comments in the form of javadoc. Let me know your thoughts.

@paulyuk paulyuk mentioned this pull request Feb 13, 2022
Closed
4 tasks
@pravinpushkar
Incorporating review comments
425412f 
Signed-off-by: Pravin Pushkar <[email protected]>
paulyuk
paulyuk approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you for contributions and addressing feedback

@artursouza artursouza closed this Feb 15, 2022
@artursouza artursouza force-pushed the feature/new_quickstarts branch from 2201192 to d799eb0 Compare February 15, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amulyavarote amulyavarote amulyavarote left review comments

@paulyuk paulyuk paulyuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pravinpushkar @amulyavarote @paulyuk @artursouza @hhunter-ms @XavierGeerinck @greenie-msft