Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the client is actual built #517

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Conversation

XavierGeerinck
Copy link
Contributor

Description

Fix client build for react calculator

@msfussell msfussell self-requested a review January 20, 2022 17:17
Copy link
Member

@msfussell msfussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msfussell msfussell merged commit 482a0e4 into dapr:master Jan 20, 2022
dmitsh pushed a commit that referenced this pull request Jan 21, 2022
dmitsh pushed a commit that referenced this pull request Jan 24, 2022
* Make sure the client is actual built (#517)

Signed-off-by: Xavier Geerinck <[email protected]>

* Update DevContainer base image to fix CodeSpaces and DevContainer issues (#519)

* Update base image to later Universal 1.x Focal, but still pin to 1.x major version

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updated readme to clarify pre-req SKUs for GitHub CodeSpaces support

Signed-off-by: Paul Yuknewicz <[email protected]>

Co-authored-by: Mukundan Sundararajan <[email protected]>

* Setting FLASK_RUN_PORT=5001 in distributed-calc

Signed-off-by: Charlie Stanley <[email protected]>

Co-authored-by: Xavier Geerinck <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Charlie Stanley <[email protected]>
dmitsh pushed a commit that referenced this pull request Jan 24, 2022
* Make sure the client is actual built (#517)

Signed-off-by: Xavier Geerinck <[email protected]>

* Update DevContainer base image to fix CodeSpaces and DevContainer issues (#519)

* Update base image to later Universal 1.x Focal, but still pin to 1.x major version

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updated readme to clarify pre-req SKUs for GitHub CodeSpaces support

Signed-off-by: Paul Yuknewicz <[email protected]>

Co-authored-by: Mukundan Sundararajan <[email protected]>

* Setting FLASK_RUN_PORT=5001 in distributed-calc

Signed-off-by: Charlie Stanley <[email protected]>

Co-authored-by: Xavier Geerinck <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Charlie Stanley <[email protected]>
dmitsh pushed a commit that referenced this pull request Jan 24, 2022
* Make sure the client is actual built (#517)

Signed-off-by: Xavier Geerinck <[email protected]>

* Update DevContainer base image to fix CodeSpaces and DevContainer issues (#519)

* Update base image to later Universal 1.x Focal, but still pin to 1.x major version

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updated readme to clarify pre-req SKUs for GitHub CodeSpaces support

Signed-off-by: Paul Yuknewicz <[email protected]>

Co-authored-by: Mukundan Sundararajan <[email protected]>

* Setting FLASK_RUN_PORT=5001 in distributed-calc

Signed-off-by: Charlie Stanley <[email protected]>

Co-authored-by: Xavier Geerinck <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Charlie Stanley <[email protected]>
msfussell pushed a commit that referenced this pull request Jan 25, 2022
* replace ports 5000/7000 with 5001/7001 to eliminate conflict with Control Center on MacOS (#521)

Signed-off-by: Dmitry Shmulevich <[email protected]>

* Sync master into release-1.6 (#523)

* Make sure the client is actual built (#517)

Signed-off-by: Xavier Geerinck <[email protected]>

* Update DevContainer base image to fix CodeSpaces and DevContainer issues (#519)

* Update base image to later Universal 1.x Focal, but still pin to 1.x major version

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updated readme to clarify pre-req SKUs for GitHub CodeSpaces support

Signed-off-by: Paul Yuknewicz <[email protected]>

Co-authored-by: Mukundan Sundararajan <[email protected]>

* Setting FLASK_RUN_PORT=5001 in distributed-calc

Signed-off-by: Charlie Stanley <[email protected]>

Co-authored-by: Xavier Geerinck <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Charlie Stanley <[email protected]>

* update README (#524)

Signed-off-by: Dmitry Shmulevich <[email protected]>

Co-authored-by: Charlie Stanley <[email protected]>
Co-authored-by: Xavier Geerinck <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Charlie Stanley <[email protected]>
Arashrohani pushed a commit to Arashrohani/quickstarts that referenced this pull request Feb 16, 2022
Signed-off-by: Xavier Geerinck <[email protected]>
Signed-off-by: Arash Rohani <[email protected]>
Arashrohani pushed a commit to Arashrohani/quickstarts that referenced this pull request Feb 16, 2022
* replace ports 5000/7000 with 5001/7001 to eliminate conflict with Control Center on MacOS (dapr#521)

Signed-off-by: Dmitry Shmulevich <[email protected]>

* Sync master into release-1.6 (dapr#523)

* Make sure the client is actual built (dapr#517)

Signed-off-by: Xavier Geerinck <[email protected]>

* Update DevContainer base image to fix CodeSpaces and DevContainer issues (dapr#519)

* Update base image to later Universal 1.x Focal, but still pin to 1.x major version

Signed-off-by: Paul Yuknewicz <[email protected]>

* Updated readme to clarify pre-req SKUs for GitHub CodeSpaces support

Signed-off-by: Paul Yuknewicz <[email protected]>

Co-authored-by: Mukundan Sundararajan <[email protected]>

* Setting FLASK_RUN_PORT=5001 in distributed-calc

Signed-off-by: Charlie Stanley <[email protected]>

Co-authored-by: Xavier Geerinck <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Charlie Stanley <[email protected]>

* update README (dapr#524)

Signed-off-by: Dmitry Shmulevich <[email protected]>

Co-authored-by: Charlie Stanley <[email protected]>
Co-authored-by: Xavier Geerinck <[email protected]>
Co-authored-by: Paul Yuknewicz <[email protected]>
Co-authored-by: Mukundan Sundararajan <[email protected]>
Co-authored-by: Charlie Stanley <[email protected]>
Signed-off-by: Arash Rohani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants