Updated .NET workflow method names #4586
Merged
+9
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Whit Waldo <[email protected]>
|
Stale PR, paging all reviewers |
|
Stale PR, paging all reviewers |
|
@alicejgibbons I'd appreciate a review of this if you've got the time. |
alicejgibbons
suggested changes
Apr 9, 2025
|
|
||
| // Purge the workflow, removing all inbox and history information from associated instance | ||
| await daprClient.PurgeWorkflowAsync(orderId, workflowComponent); | ||
| await daprWorkflowClient.PurgeWorkflowAsync(orderId); |
There was a problem hiding this comment.
I dont see PurgeWorkflowAsync only PurgeInstanceAsync? https://github.com/dapr/dotnet-sdk/blob/32d06a7136a4e32a70e02398619442d28f120165/src/Dapr.Workflow/DaprWorkflowClient.cs#L288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for helping make the Dapr documentation better!
Please follow this checklist before submitting:
In addition, please fill out the following to help reviewers understand this pull request:
Description
Most of the workflow method names, descriptions and signatures were incorrect, so this PR corrects them.
Thanks for the ping @msfussell !
Issue reference