Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add conversation Ollama component ref #4578

Closed
wants to merge 6 commits into from

Conversation

ManuInNZ
Copy link

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • Read the contribution guide
  • Commands include options for Linux, MacOS, and Windows within codetabs
  • New file and folder names are globally unique
  • Page references use shortcodes instead of markdown or URL links
  • Images use HTML style and have alternative text
  • Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Component ref doc for ollama contrib dapr/components-contrib#3688

Issue reference

N/A

@ManuInNZ ManuInNZ requested review from a team as code owners March 14, 2025 11:41
Copy link

Stale PR, paging all reviewers

Copy link
Contributor

@cicoyle cicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the docs! 🎉

Copy link

github-actions bot commented Apr 1, 2025

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 1, 2025
@ManuInNZ
Copy link
Author

ManuInNZ commented Apr 1, 2025 via email

@cicoyle cicoyle removed the stale label Apr 1, 2025
@cicoyle
Copy link
Contributor

cicoyle commented Apr 1, 2025

cc @hhunter-ms & @msfussell please do a final pass on this PR

Copy link

github-actions bot commented Apr 7, 2025

Stale PR, paging all reviewers

@github-actions github-actions bot added the stale label Apr 7, 2025
@ManuInNZ
Copy link
Author

contrib approved

@ManuInNZ ManuInNZ changed the title feat: ✨ Add conversation Ollama component ref feat: Add conversation Ollama component ref Apr 10, 2025
@ManuInNZ
Copy link
Author

@msfussell Same here? 1.16 ?

@cicoyle cicoyle removed the stale label Apr 10, 2025
@cicoyle
Copy link
Contributor

cicoyle commented Apr 10, 2025

@msfussell - can you review this docs PR? PRs upstream to dapr and components contrib are merged now, so we are good to go here.

@cicoyle cicoyle requested a review from msfussell April 10, 2025 23:29
@msfussell
Copy link
Member

msfussell commented Apr 11, 2025

@msfussell Same here? 1.16 ?

Yes, this also needs to be in 1.16 docs branch. However, see my comment here #4579 (comment)

@ManuInNZ ManuInNZ closed this Apr 12, 2025
@ManuInNZ
Copy link
Author

ManuInNZ commented Apr 12, 2025

Moving to new PR based on 1.16

@ManuInNZ
Copy link
Author

created #4612

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants