Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Zeebe to version 1.0 #876

Merged
merged 10 commits into from
Jun 11, 2021
Merged

Update Zeebe to version 1.0 #876

merged 10 commits into from
Jun 11, 2021

Conversation

akkie
Copy link
Contributor

@akkie akkie commented May 18, 2021

Description

This PR updates the Zeebe binding so that it reflects the changes for version 1.0. which was released recently.

https://docs.camunda.io/docs/guides/update-guide/026-to-100/

The PR doesn't create a new version of the binding because the Zeebe binding wasn't officially released.

Issue reference

Fixes #875

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

@pkedy pkedy self-assigned this May 18, 2021
@pkedy
Copy link
Member

pkedy commented Jun 9, 2021

@akkie Can you resolve the conflicts?

@akkie
Copy link
Contributor Author

akkie commented Jun 10, 2021

@pkedy All conflicts are resolved

Copy link
Member

@pkedy pkedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/cc @artursouza

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #876 (42f3b54) into master (9cd7de9) will decrease coverage by 0.09%.
The diff coverage is 21.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #876      +/-   ##
==========================================
- Coverage   35.54%   35.44%   -0.10%     
==========================================
  Files         135      135              
  Lines       10646    10642       -4     
==========================================
- Hits         3784     3772      -12     
- Misses       6480     6489       +9     
+ Partials      382      381       -1     
Impacted Files Coverage Δ
bindings/zeebe/client.go 27.27% <ø> (ø)
bindings/zeebe/command/complete_job.go 64.70% <ø> (ø)
bindings/zeebe/command/update_job_retries.go 71.42% <ø> (ø)
bindings/zeebe/jobworker/jobworker.go 12.35% <0.00%> (-2.31%) ⬇️
bindings/zeebe/command/deploy_process.go 12.50% <12.50%> (ø)
bindings/zeebe/command/cancel_instance.go 66.66% <25.00%> (ø)
bindings/zeebe/command/command.go 87.50% <100.00%> (ø)
bindings/zeebe/command/create_instance.go 77.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cd7de9...42f3b54. Read the comment docs.

Copy link
Member

@artursouza artursouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, make this change backwards compatible. If the upgrade is not backwards compatible, then it should be implemented a new component version and keep the existing code.

@artursouza
Copy link
Member

@artursouza artursouza merged commit 3689020 into dapr:master Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Zeebe to version 1.0
3 participants