-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Zeebe to version 1.0 #876
Conversation
@akkie Can you resolve the conflicts? |
@pkedy All conflicts are resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/cc @artursouza
Codecov Report
@@ Coverage Diff @@
## master #876 +/- ##
==========================================
- Coverage 35.54% 35.44% -0.10%
==========================================
Files 135 135
Lines 10646 10642 -4
==========================================
- Hits 3784 3772 -12
- Misses 6480 6489 +9
+ Partials 382 381 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, make this change backwards compatible. If the upgrade is not backwards compatible, then it should be implemented a new component version and keep the existing code.
Looking at our documentation, this component is not in GA. So, it can be a breaking change. This change is OK. https://docs.dapr.io/operations/components/certification-lifecycle/#alpha |
Description
This PR updates the Zeebe binding so that it reflects the changes for version 1.0. which was released recently.
https://docs.camunda.io/docs/guides/update-guide/026-to-100/
The PR doesn't create a new version of the binding because the Zeebe binding wasn't officially released.
Issue reference
Fixes #875
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: