Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp validation & improved req validation #35

Merged
merged 1 commit into from
May 15, 2024

Conversation

Marketen
Copy link
Contributor

@Marketen Marketen commented May 14, 2024

closes #22

  • renamed "IsValidSignature" into VerifySignature
  • added timestamp validation (we dont accept timestamps older than 30 days)
  • refactored and improved request validation overall
  • added usecases in request validation tests

@Marketen Marketen self-assigned this May 14, 2024
@pablomendezroyo pablomendezroyo merged commit fdb87d4 into main May 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add timestamp validation so not old signatures get inserted into db
2 participants