Refactor #207
Closed
Refactor #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablomendezroyo
force-pushed
the
pablo/dappmanager-dependency
branch
from
62edf47 to
328eac1
Compare
|
DAppNode bot has built and pinned the release to an IPFS node, for commit: 232d061 This is a development version and should only be installed for testing purposes, install link (by dappnodebot/build-action) |
pablomendezroyo
force-pushed
the
pablo/dappmanager-dependency
branch
from
c538381 to
b2bf8e2
Compare
setup manifest test Setup processError as generic function Implementing compose schema tests fixed compose validation implement setupwizard tests fix typo fix typo fix test init and build
simplify compose code
abstracted writeReleaseFile for compose manifest and wizard
pablomendezroyo
force-pushed
the
pablo/dappmanager-dependency
branch
from
b2e586d to
c0d021d
Compare
pablomendezroyo
force-pushed
the
pablo/dappmanager-dependency
branch
from
6828cfe to
a5e1ca9
Compare
dapplion
requested changes
May 19, 2022
| @@ -115,9 +102,6 @@ export const releaseFilesDefaultNames: { | |||
| compose: "docker-compose.yml", | |||
| avatar: "avatar.png", | |||
| setupWizard: "setup-wizard.json", | |||
| setupSchema: "setup.schema.json", | |||
| setupTarget: "setup-target.json", | |||
| setupUiJson: "setup-ui.json", | |||
There was a problem hiding this comment.
We cannot merge this change until there's hard proof that no package is using the old setup wizard v1 feature
pablomendezroyo
force-pushed
the
pablo/dappmanager-dependency
branch
2 times, most recently
from
e05e0ae to
96498af
Compare
abstracted getReleaseFilePath abstracted readReleaseFile file structure reorg add issues template for compose setupwizard and manifest reorg code set release automatically on schema changes set sdk releases manually Setup compose schema relocate types defined specs and added types Move compose validation to sdk stop progress add safeCompose added parseComposeToProduction remove issues_templates set workflow old bump node ci version change readReleasFile types return fix tests fix use a new global ajv instance for each releaseFIle add ajv errros
pablomendezroyo
force-pushed
the
pablo/dappmanager-dependency
branch
from
0c58520 to
232d061
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
DAppNodeSDK is a critical dappnode tool used daily in Github actions. It has not received maintenance from a long time ago and some things are out of date.
Furthermore, there is code duplicated between dappmanager and the SDK:
This code duplication makes the developing experience annoying and results in production errors due to missed updates to both repositories
Approach
The SDK should contain all the types and validating functions, then the dappmanager should use the DAppNodeSDK as a dependency and import these types and validating functions to be used in during the packages installation. This will benefit DAppNode in a better development experience, fewer bugs in production, easier implementation for new wizard/manifest/compose keys features, etc.
Roadmap
setupWizard,gettingStarted...)yarn linkto use this PR as a dependency