Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wei calculations when sending value #790

Closed
wants to merge 1 commit into from

Conversation

nanexcool
Copy link
Contributor

@nanexcool nanexcool commented Sep 13, 2021

PR #782 messed up value calculations! Before sending -V 1 would send 1 wei, now it sends 1 ETH.

@transmissions11
Copy link
Contributor

Yikes good catch 😬

What's the point of using --to-wei here at all here btw? Isn't it a noop?

@nanexcool
Copy link
Contributor Author

Yikes good catch 😬

What's the point of using --to-wei here at all here btw? Isn't it a noop?

lol yeah probably, I just went through every file quickly coz I was freaking out hahaha

also will have to add tests to the integration suite so this doesn't happen again

@d-xo
Copy link
Contributor

d-xo commented Sep 13, 2021

What's the point of using --to-wei here at all here btw? Isn't it a noop?

I think it would let you do seth send -V "1 eth"?

@d-xo
Copy link
Contributor

d-xo commented Sep 13, 2021

reverted the offending commit in #791

@nanexcool nanexcool closed this Sep 13, 2021
@nanexcool nanexcool deleted the fix-wei branch September 13, 2021 17:58
@d-xo
Copy link
Contributor

d-xo commented Sep 14, 2021

I'm still OK with merging something that changes the default for --to-wei btw, as long as it's been thoroughly tested and we've checked all locations where it's currently used to make sure we're not breaking something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants