Implementation of CSR/CSR Matrix Multiplication (@)
#799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some test cases would be awesome. Maybe something similar to the dense mat mult test? |
This was
linked to
issues
Aug 1, 2024
Thanks, I'll definetly take a look at it! |
This commit implements SpGEMM on CPU without transpose support. For more details see GitHub issue daphne-eu#793. Closes daphne-eu#799, Fixes daphne-eu#793
This commit adds a quick fix to not merge transpose operations into sparse matrix multiplication as our CPP kernels can not handle this. The temporary workaround until we support transposition uses a hard coded sparsity threshold as there is no user config available in the canonicalization. The matrix representation selection functionality would also be a suitable measure but is not implemented in a suitable way for this at the moment.
corepointer
force-pushed
the
mat_mult_csr_csr_no_transpose
branch
from
d11f24f to
e6cd72a
Compare
|
Thx for submitting this PR @GuilloteauQ. I merged with some cleanup and test cases and added a commit that circumvents the missing transposition functionality. Since you implemented this already as mentioned in #793 I'd kindly ask you to provide this implementation as well. Ideally you can also modify the compiler logic to use the method with or w/o the transposition depending on the situation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a kernel for the matrix multiplication between two CSR matrices.
Related Issue: #793
Fixes also #783
Questions
kernels.json? like for other types thandouble