[DAPHNE-#687] OneHot bound check #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - thx for fixing this. I'd merge this later today if no further discussion comes up. |
This commit fixes the bounds checks of the onehot kernel, adds a zero mode, replaces the assertions, adds test cases and documentation. Closes daphne-eu#695
corepointer
force-pushed
the
OneHot-bounds-check
branch
from
3c88a6c to
81b1142
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #687 by adding a simple bound check for the
cArgvalue used for the OneHot encoding. Previous asserts have been replaced with runtime errors and are tested inOneHotTest.cpp. The loop setting all values within an encoded segment to zero is now also a singlememsetinstruction.Onehot now also accepts
0as an argument forinfo, which signals to omit the corresponding column instead of encoding or copying it tores. Currently, if all values ininfoare0a runtime error is thrown. This could be changed to return an emptyresinstead.