Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DAPHNE-#492] Creating Subframe of Frame with zero rows #496

Merged
merged 4 commits into from
Apr 11, 2023
Merged

[DAPHNE-#492] Creating Subframe of Frame with zero rows #496

merged 4 commits into from
Apr 11, 2023

Conversation

tomschw
Copy link
Contributor

@tomschw tomschw commented Apr 6, 2023 •
edited
Loading

Fixed problem:

  • Crash when trying to use the Frame constructor which creates a sub-frame without copying data, when using a source Frame with zero rows.

Changes:

  • Add test which reproduces the problem.
  • Fix by excluding the assertions of the constructor when source Frame has zero rows and the expected boundaries of the new frame are both zero.

Fixes #492.

tomschw added 4 commits April 6, 2023 17:35
@tomschw
Add test to check for crashes when creating sub-frame
3fc236e 
from Frame with zero rows.
@tomschw
Fix test for the creation of a sub-frame from
a9b85be 
a Frame with zero rows to check if data
pointers are the same.
@tomschw
Add fix to enable creation of a sub-frame with
8edb533 
zero rows from a Frame with zero rows, by excluding
the assertions.
@tomschw
Remove newline at end of testfile.
d880c86
@pdamme pdamme self-requested a review April 11, 2023 15:26
pdamme
pdamme approved these changes Apr 11, 2023
View reviewed changes
Copy link
Collaborator

@pdamme pdamme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix, @tomschw. It looks very good to me. Congrats on your first contribution to DAPHNE!

@pdamme pdamme merged commit 724e3cd into daphne-eu:main Apr 11, 2023
This was referenced Apr 11, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdamme pdamme pdamme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating Subframe of Frame with zero rows
2 participants
@tomschw @pdamme