[DAPHNE-#419] Guidelines on handling pull requests #430
Conversation
pdamme
commented
Oct 5, 2022
•
pdamme
commented
- This initial draft mainly summarizes how we have handled pull requests so far.
- Furthermore, it goes beyond that at some points (e.g., quick initial summary and reviewer selection process).
- The focus is mostly on the overall process of handling a PR.
- Closes Set up guidelines for handling/merging in PRs #419.
- This initial draft mainly summarizes how we have handled pull requests so far. - Furthermore, it goes beyond that at some points (e.g., quick initial summary and reviewer selection process). - Closes #419.
pdamme
force-pushed
the
419-guidelines-handling-prs
branch
from
395923e to
48a3786
Compare
|
@corepointer I would appreciate if you could have a look once you find some time. |
corepointer
added
the
doc
There was a problem hiding this comment.
LGTM - Thank you for that quite thourough guide.
I have addressed one of the TODOs about how to use git on the command line. The other TODOs will remain until we have sorted out the mentioned issues (TODO: create those issues in the tracker)
I'd follow the guide and press the squash and merge button later if you re-approve my changes =)
|
Thanks @corepointer for looking over it and adding some of the missing pieces. Your changes are hereby approved :) (I cannot formally review it, because I've opened it). Feel free to merge this PR. |
|
I think with that we have at least a starting point. Let's try to follow these guidelines from now on, and let's see this as a living document, which we update whenever we notice that something is missing or could be improved. This is also meant as an invitation to everyone to contribute to these guidelines and share their opinions on them. |
