CSRMatrix to Dense Matrix CastOpt and vise versa #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- See documentation of Matrix::set(). - This made the test case CastObj "DenseMatrix to CSRMatrix" fail on my system.
- Removed .vscode directory. - Kernel: - Renamed some template parameters for consistency. - Added todo on potential for improving performance. - Test cases: - Renamed some template parameters for consistency. - Testing with more value types, but without duplicating the test cases (providing a list of value types to the test cases).
pdamme
force-pushed
the
CastOpt-Dense-to-CSR-and-CSR-to-Dense-129-130
branch
from
7339b1f to
a3e19df
Compare
pdamme
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Thanks for this PR, @KostasBitsakos! It looks very good to me. I rebased your commits onto the main branch of your fork and applied some minor polishing and clean-up. I also fixed a minor bug: Using set() requires the data object to be in a structurally valid state (see documentation of Matrix::set()); for CSRMatrix this means its underlying arrays must have been initialized (or otherwise prepared, e.g., by prepareAppend()). You can view my changes in the commits tab on the PR's page.
Congrats on your first contribution to the codebase :) .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.