[DAPHNE-#356]: type casting of DenseMatrix #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CastObj has already implementation of DenseMatrix<ValueType> to DenseMatrix<ResultValueType>, but kernels.json was missing the declarations.
aristotelis96
changed the title
pdamme
approved these changes
May 12, 2022
There was a problem hiding this comment.
Thanks @aristotelis96, looks very good. I think it's indeed a good idea to add the remaining type combinations right now (taking the currently supported value types into account).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CastObj kernel has already specialized implementation for
DenseMatrix<ValueType>toDenseMatrix<ResultValueType>, butkernels.jsonwas missing the declarations.I open this PR as a Draft in case we want to include more cases.
Closes #356.