Fix unclaimed redeemers list #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orenyodfat
reviewed
May 1, 2019
src/domain/proposal.ts
Outdated
| @@ -204,6 +205,8 @@ export function updateCRProposal( | |||
| setSchemeName(proposal.scheme, 'ContributionReward'); | |||
| getProposalIPFSData(proposal); | |||
|
|
|||
| addRedeemableRewardOwner(proposalId, beneficiary); | |||
There was a problem hiding this comment.
To make sure the beneficiary is listed as a redeemer
orenyodfat
reviewed
May 1, 2019
src/domain/reward.ts
Outdated
| @@ -81,6 +81,32 @@ export function reputationRedemption(proposalId: Bytes, beneficiary: Address, ti | |||
| } | |||
|
|
|||
| function shouldRemoveAccountFromUnclaimed(reward: GPReward): boolean { | |||
| let proposal = getProposal(reward.proposal); | |||
| if (proposal.contributionReward !== null) { | |||
| let crProposal = store.get( | |||
There was a problem hiding this comment.
please use ContributionRewardProposal.load
orenyodfat
reviewed
May 1, 2019
src/domain/reward.ts
Outdated
| @@ -81,6 +81,32 @@ export function reputationRedemption(proposalId: Bytes, beneficiary: Address, ti | |||
| } | |||
|
|
|||
| function shouldRemoveAccountFromUnclaimed(reward: GPReward): boolean { | |||
| let proposal = getProposal(reward.proposal); | |||
There was a problem hiding this comment.
why need this ?
use ContributionRewardProposal.load(pid) and check if its not null.
|
please add tests to cover this issue. |
orenyodfat
suggested changes
May 1, 2019
orenyodfat
reviewed
May 1, 2019
| @@ -81,6 +81,28 @@ export function reputationRedemption(proposalId: Bytes, beneficiary: Address, ti | |||
| } | |||
|
|
|||
| function shouldRemoveAccountFromUnclaimed(reward: GPReward): boolean { | |||
| let proposal = ContributionRewardProposal.load(reward.proposal); | |||
| if (proposal !== null) { | |||
| if (equalsBytes(proposal.beneficiary, reward.beneficiary)) { | |||
There was a problem hiding this comment.
does this cover by any test?
orenyodfat
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #206