Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grom72/sre 2832 #15980

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Grom72/sre 2832 #15980

wants to merge 8 commits into from

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Feb 26, 2025

Steps for the author:

  • Commit message follows the guidelines.
  • Appropriate Features or Test-tag pragmas were used.
  • At least two positive code reviews including at least one code owner from each category referenced in the PR.
  • Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

  • Gatekeeper requested (daos-gatekeeper added as a reviewer).

Update Jenkinsfiles to support SCRIPT_SPLITTING_TRANSFORMATION per
https://issues.jenkins.io/browse/JENKINS-56500

utils/githooks/README.md: Fix markuplint flagged issues.

utils/scripts/helpers/install_maldet.ch :
  Fix defaults to be more implementation neutral.

utils/scripts/helpers/repo-helper-*.sh :
  Optionally install CA needed to validate local repository mirrors.

Dockerfiles modified to support intalling the CA.

Dockerfile.code_scanning modified to allow specifying the fedora
version used.

Signed-off-by: John E. Malmberg <[email protected]>
Copy link

Errors are component not formatted correctly,Ticket number prefix incorrect,PR title is malformatted. See https://daosio.atlassian.net/wiki/spaces/DC/pages/11133911069/Commit+Comments,Unable to load ticket data
https://daosio.atlassian.net/browse/Grom72/sre

@@ -8,7 +9,7 @@
# Pull base image
ARG POINT_RELEASE=
ARG BASE_DISTRO=rockylinux/rockylinux:8$POINT_RELEASE
FROM $BASE_DISTRO as basic
FROM $BASE_DISTRO AS basic

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Click Remediation section below to solve this issue
@@ -8,7 +9,7 @@
# Pull base image
ARG POINT_RELEASE=
ARG BASE_DISTRO=registry.opensuse.org/opensuse/leap-dnf:15$POINT_RELEASE
FROM $BASE_DISTRO as basic
FROM $BASE_DISTRO AS basic

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Click Remediation section below to solve this issue
@@ -4,38 +4,24 @@
# 'recipe' for Docker to build an Debian package
#
# Pull base image
FROM ubuntu:20.04
ARG BASE_DISTRO=ubuntu:20.04
FROM $BASE_DISTRO

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Click Remediation section below to solve this issue
@grom72 grom72 force-pushed the grom72/sre-2832 branch 4 times, most recently from 3ec373d to f8698d0 Compare February 26, 2025 10:44
Signed-off-by: Tomasz Gromadzki <[email protected]>
Signed-off-by: Tomasz Gromadzki <[email protected]>
Signed-off-by: Tomasz Gromadzki <[email protected]>
Let's enable it when jenkins3@hpe is available

Cancel-prev-build: false

Signed-off-by: Tomasz Gromadzki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants