Merge pull request #68 from jeromelaban/dev/jela/invariant

fix: Use invariant ToLower
dansiegel · Dec 12, 2024 · e23ba6f · e23ba6f
2 parents 4956c75 + 1e76368
commit e23ba6f
Show file tree

Hide file tree

Showing 7 changed files with 53 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -35,7 +35,7 @@ jobs:
         run: dotnet test "${{ env.WORKING_DIRECTORY }}" --no-build -c Release
 
       - name: Upload Artifacts
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: NuGet
           path: Artifacts/

diff --git a/src/CodeGenHelpers/ClassBuilder.cs b/src/CodeGenHelpers/ClassBuilder.cs
@@ -338,7 +338,7 @@ internal override void Write(in CodeWriter writer)
                 IsSealed ? "sealed" : null,
                 IsAbstract ? "abstract" : null,
                 _isPartial ? "partial" : null,
-                Kind.ToString().ToLower(),
+                Kind.ToString().ToLowerInvariant(),
                 $"{Name}{_generics}",
                 extra
             };

diff --git a/src/CodeGenHelpers/CodeBuilder.cs b/src/CodeGenHelpers/CodeBuilder.cs
@@ -195,7 +195,7 @@ private CodeWriter BuildInternal()
                 writer.NewLine();
 
             if(_nullable != NullableState.Default)
-                writer.AppendLine($"#nullable {_nullable}".ToLower());
+                writer.AppendLine($"#nullable {_nullable}".ToLowerInvariant());
 
             WriteAssemblyAttributes(_assemblyAttributes, ref writer);
             if(_topLevel)

diff --git a/src/CodeGenHelpers/ConstructorBuilder.cs b/src/CodeGenHelpers/ConstructorBuilder.cs
@@ -201,7 +201,7 @@ internal override void Write(in CodeWriter writer)
 
             var modifier = AccessModifier switch
             {
-                null => Class.AccessModifier.ToString().ToLower(),
+                null => Class.AccessModifier.ToString().ToLowerInvariant(),
                 _ => AccessModifier.Code()
             };
             var parameters = _parameters.Any() ? string.Join(", ", _parameters.Select(x => x.ToString())) : string.Empty;

diff --git a/src/CodeGenHelpers/Internals/AccessibilityExtensions.cs b/src/CodeGenHelpers/Internals/AccessibilityExtensions.cs
@@ -11,7 +11,7 @@ internal static class AccessibilityExtensions
                 Accessibility.ProtectedAndInternal => "private protected",
                 Accessibility.ProtectedOrInternal => "protected internal",
                 Accessibility.NotApplicable => null,
-                _ => accessModifier.ToString().ToLower()
+                _ => accessModifier.ToString().ToLowerInvariant()
             };
 
         public static string? Code(this Accessibility? accessModifier) =>

diff --git a/tests/CodeGenHelpers.Tests/SampleCode/InternalClass.cs b/tests/CodeGenHelpers.Tests/SampleCode/InternalClass.cs
@@ -0,0 +1,15 @@
+//------------------------------------------------------------------------------
+// <auto-generated>
+//     This code was generated.
+//
+//     Changes to this file may cause incorrect behavior and will be lost if
+//     the code is regenerated.
+// </auto-generated>
+//------------------------------------------------------------------------------
+
+namespace CodeGenHelpers.SampleCode
+{
+    internal partial class InternalClass
+    {
+    }
+}
diff --git a/tests/CodeGenHelpers.Tests/Tests/ClassTests.cs b/tests/CodeGenHelpers.Tests/Tests/ClassTests.cs
@@ -1,4 +1,6 @@
-using Microsoft.CodeAnalysis;
+using System.Globalization;
+using System.Threading;
+using Microsoft.CodeAnalysis;
 using Xunit;
 using Xunit.Abstractions;
 
@@ -41,6 +43,36 @@ public void GenerateGenericClassWithConstraint()
             MakeAssertion(builder);
         }
 
+        [Fact]
+        public void GenerateInternalClass()
+        {
+            var builder = CodeBuilder.Create(Namespace)
+                .AddClass("InternalClass")
+                .WithAccessModifier(Accessibility.Internal);
+
+            MakeAssertion(builder);
+        }
+
+        [Fact]
+        public void GenerateInternalClassTurkish()
+        {
+            var currentCulture = Thread.CurrentThread.CurrentCulture;
+            Thread.CurrentThread.CurrentCulture = new CultureInfo("tr-TR");
+
+            try
+            {
+                var builder = CodeBuilder.Create(Namespace)
+                    .AddClass("InternalClass")
+                    .WithAccessModifier(Accessibility.Internal);
+
+                MakeAssertion(builder);
+            }
+            finally
+            {
+                Thread.CurrentThread.CurrentCulture = currentCulture;
+            }
+        }
+
         [Fact]
         public void GenerateGenericClassWithComplexConstraint()
         {