Add Explicit Includes in most headers #4389
Closed
+95
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s to resolve issues caused by unity builds interfering with LSP functionality. This ensures better code clarity and maintainability.
|
lgtm |
|
I can't this ass compiler has to be a pain in the ass as always. |
danielkrupinski
requested changes
Jan 23, 2025
Comment on lines
+334
to
+337
|
|
||
| compile_commands.json | ||
| .cache |
There was a problem hiding this comment.
Don't make unnecessary changes.
| @@ -21,7 +22,7 @@ class WatchedSounds { | |||
|
|
|||
| [[nodiscard]] bool hasSound(int soundGuid) const noexcept | |||
| { | |||
| // can not use std::ranges::find() because it tries to link with __std_find_trivial_4 | |||
| // can not use std::ranges::find() because it tries to link with __std_find_trivial_4 (then why no use std::find) | |||
There was a problem hiding this comment.
Don't make unnecessary changes. The comment applies also to std::find.
| @@ -1,8 +1,8 @@ | |||
| #pragma once | |||
|
|
|||
| #include <array> | |||
There was a problem hiding this comment.
std::array is used in this file
| #include "HostageOutlineGlowContext.h" | ||
| #include <Features/Visuals/OutlineGlow/GrenadeProjectileOutlineGlow/GrenadeProjectileOutlineGlowContext.h> |
There was a problem hiding this comment.
HostageOutlineGlowContext is the correct one here. GrenadeProjectileOutlineGlowContext is just wrongly used below.
| @@ -1,6 +1,6 @@ | |||
| #pragma once | |||
|
|
|||
| #include <algorithm> | |||
There was a problem hiding this comment.
std::ranges::lower_bound() is from <algorithm>
| @@ -4,6 +4,8 @@ | |||
| #include <CS2/Classes/Color.h> | |||
| #include <GameClasses/SceneObject.h> | |||
| #include <Platform/Macros/IsPlatform.h> | |||
| #include <MemoryPatterns/Linux/GlowSceneObjectPatternsLinux.h> | |||
There was a problem hiding this comment.
This will cause build error on Windows - use MemoryPatterns/PatternTypes/ClientPatternTypes.h instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added explicit includes for all necessary dependencies in header files to resolve issues caused by unity builds interfering with LSP functionality. This ensures better code clarity and maintainability. Also removed some useless imports. Project still builds and works on linux, windows has not been tested.