Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#607 switched to ConcurrentHashSet. #608

Merged
merged 1 commit into from
Aug 8, 2020
Merged

#607 switched to ConcurrentHashSet. #608

merged 1 commit into from
Aug 8, 2020

Conversation

andrx
Copy link
Contributor

@andrx andrx commented Jul 23, 2020

No description provided.

@selmiskr
Copy link

selmiskr commented Jul 30, 2020 •
edited
Loading

This should solve the following Exception we are occasionally getting in a multi-service (multi-threaded) environment.

System.IndexOutOfRangeException: Index was outside the bounds of the array. at System.Collections.Generic.HashSet1.SetCapacity(Int32 newSize) at System.Collections.Generic.HashSet1.AddIfNotPresent(T value) at WorkflowCore.Services.BackgroundTasks.QueueConsumer.Execute()

https://stackoverflow.com/questions/4307131/indexoutofrangeexception-when-adding-to-hashsett

Let's be sure that this PR also resolves this issue

@selmiskr
Copy link

I also created an issue for this #414

@andrx andrx marked this pull request as ready for review July 30, 2020 18:10
@andrx
Copy link
Contributor Author

andrx commented Jul 30, 2020

yes, this change worked for me as well but @danielgerlag asked to switch to ConcurrentDictionary. Just need a moment to update the PR.

@danielgerlag danielgerlag merged commit 8901abf into danielgerlag:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrx @selmiskr @danielgerlag