Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TJWT.IsValidToken does not return an error string on invalid signature #574

Closed
DeddyH opened this issue Sep 10, 2022 · 0 comments
Closed

TJWT.IsValidToken does not return an error string on invalid signature #574

DeddyH opened this issue Sep 10, 2022 · 0 comments
Assignees
@danieleteti
Labels
accepted Issue has been accepted and inserted in a future milestone enhancement
Milestone
3.2.2-nitrogen

Comments

@DeddyH
Copy link

DeddyH commented Sep 10, 2022

My suggestion is to set the out-parameter "Error" to "Invalid token" at first. If all checks have been passed successfully, set it to an empty string. This would make the whole code shorter and cleaner due to only having 2 lines where this param is assigned a value.
@danieleteti danieleteti self-assigned this Sep 10, 2022
@danieleteti danieleteti added enhancement accepted Issue has been accepted and inserted in a future milestone labels Sep 10, 2022
@danieleteti danieleteti added this to the 3.2.2-nitrogen milestone Sep 10, 2022
danieleteti added a commit that referenced this issue Sep 11, 2022
@danieleteti
https://github.com/danieleteti/delphimvcframework/issues/573
057e089 
#574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieleteti danieleteti

Labels
accepted Issue has been accepted and inserted in a future milestone enhancement
Projects
None yet
Milestone
3.2.2-nitrogen
Development

No branches or pull requests
2 participants
@danieleteti @DeddyH