Global viewGenerator included in default config object
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing the library in a project, the `viewGenerator` function defined in the config object by the user did have no effect. The reason for this was that properties not included in the default config object (graph.config.js) were been ignored when building the graph and rendering it in the browser. In order to solve this issue, a `viewGenerator` property is now included in the default config object, with an initial value of `null`.
The current sandbox example created a form that allowed all of the available config properties to be customized in real time. The `viewGenerator` property, though, cannot be customized with a form. Since its value must be a function, the user cannot set it via a form field. Also, the fact that it's initialized to null made some of the sandbox examples to throw an error because the form schema generator doesn't support neither null or undefined values. Functions are not allowed either, and in this case an error would appear on screen by saying that this type of data is not supported. The current change filters the config elements so that neither null, undefined or function values are included in the config form.
danielcaldas
approved these changes
Oct 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #130 , the
viewGeneratorfunction value was been ignored when it was set in theGraphconfig object. This was probably due to the fact that theconfigobject is not stored as it comes, since its properties are filtered to match only those which exists in the default config object.This PR addresses this issue, and now it's possible to successfully add a high level
viewGeneratorfunction without having to override its value for every node in the graph.