Hk issue 776 #777
Merged
Hk issue 776 #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For github to render markdown in tables there has to be some space around the message. This will add a <p> and render the markdown. However, it also leads to some funky vertical spacing due to the nature of some browser styling for the <p> tag. This commit looks at the message to determine if it contains markdown, if yes, then add the space for proper rendering. If not, render the compacter table to get nice vertical alignment.
hanneskaeufler
commented
Nov 27, 2018
| } | ||
|
|
||
| function containsMarkdown(message: string): boolean { | ||
| return message.match(/[`*_~\[]+/g) ? true : false |
There was a problem hiding this comment.
That's pretty naive 🤷🏼♂️
hanneskaeufler
commented
Nov 27, 2018
| : violation.message | ||
|
|
||
| if (containsMarkdown(message)) { | ||
| message = `\n\n ${message}\n ` |
There was a problem hiding this comment.
This kinda keeps some weird indentation to keep the snapshots happy. Was easier to avoid breaking anything this way.
|
Yeah, cool - those make sense, thanks @hanneskaeufler - this feels good to me, I'll ship it once it's green |
|
Thanks for the PR @hanneskaeufler. This PR has been shipped in v6.1.8 - CHANGELOG. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For github to render markdown in tables there has to be some space
around the message. This will add a
<p>and render the markdown.However, it also leads to some funky vertical spacing due to the nature
of some browser styling for the
<p>tag.This PR looks at the message to determine if it contains markdown,
if yes, then add the space for proper rendering. If not, render the
compacter table to get nice vertical alignment.
Closes #776