Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 action trigger on manuel release on GitHub UI #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

enryH
Copy link

@enryH enryH commented Sep 6, 2023

  • workflow was not triggered if the instruction on p. 124f were followed

Description of issue

Following the instructions in the book,
the GitHub actions were not triggered.

Description of solution

Add release triggers as described here:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release

- workflow was not triggered if the instruction on p. 124f were followed
@enryH
Copy link
Author

enryH commented Sep 7, 2023

So this alone did not do the trick. I think the event ref just does not exist anymore, so the conditional startsWith needs to be changed additionally

@daneah
Copy link
Owner

daneah commented Sep 8, 2023

@enryH thank you for reporting this! Unfortunately this repository needs to remain static to align with the content in the book; I have suggested that I might create a living version that changes with the times (and only has one package, rather than several chapters' iterations on a package). That would be the place to fix this, to be sure. I'll leave this open and get back to you when that happens?

@enryH
Copy link
Author

enryH commented Sep 13, 2023

Hey! A live version of the repository would be great. Maybe you could test the pip package upload once a month using calendar versioning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants