GitHub tests.yml CI: explicitly specify macos-12 and use python 3.11 to test against dandi-cli #238
Conversation
…to point to arm one That one lacks pythons 3.8 and 3.9
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 87.39% 87.39%
=======================================
Files 16 16
Lines 1722 1722
=======================================
Hits 1505 1505
Misses 217 217
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
so it didn't help -- still goes for arm64: for now let's just keep good old macos-12 -- since not yet announced "deprecated" , I think we would have some time. |
Primary motivator is that macos-latest swiched to arm64 and
does not have support for python 3.8 and 3.9 . Comment in the
CI says to match version used by dandi-api for some reason.
There we use 3.11 ATM:
❯ git grep '\<3\.' -- .github/workflows/
.github/workflows/backend-ci.yml: python-version: "3.11"
.github/workflows/cli-integration.yml: - "3.11"
.github/workflows/frontend-ci.yml: python-version: '3.11'
.github/workflows/frontend-ci.yml: python-version: '3.11'
❯ git describe
v0.3.83
yarikoptic
changed the title
|
ok -- for macos-12 ones we now got tests actually ran without bailing, so provides part of the solution. But I do not get why all the rest fail whenever they do not fail e.g. in #236 . Need to have a fresh look tomorrow. |
All the failed tests seem to be failing the email requirement put in #235 which is very strange. I don't know why changing Python version has anything to do with these errors at this point, and I am not able to replicate the problem locally. |
|
ok, we need to undig CI from redness. I think this PR should be a step forward so I will merge |
The arm64 one seems to lack pythons 3.8 and 3.9. Ref: #236 (comment)