Setup pre-commit black'ing and linting similarly to dandi-cli

[yarikoptic]

No description provided.

[jwodder]

@yarikoptic It is set up; the configuration is copied directly from dandi-cli. In what way is it not working appropriately?

[yarikoptic]

@yarikoptic It is set up; the configuration is copied directly from dandi-cli.

d'oh -- my bad, indeed it is there and I see the pre-commit hooks in .git/hooks.

In what way is it not working appropriately?

for #34 I managed to do locally commit and then push to only get linters unhappy with fixes to follow in f129f15 (unused imports, comments format), and a271084 (too long lines).

May be there is a quick way to just run tox -e lint as part of the precommit to at least ensure (but IIRC for dandi-cli I have black splitting long lines etc) that I am not committing with a lint?

[satra]

just an fyi. this is the pre-commit file i'm using in nobrainer and this will take care of a lot of the issues. https://github.com/neuronets/nobrainer/blob/master/.pre-commit-config.yaml
(that repo also has the precommit-ci setup).

[jwodder]

@yarikoptic Black just does formatting; it doesn't care about unused imports. It also, for some reason, doesn't edit comments beginning with multiple #'s despite those sometimes being rejected by flake8. As for long lines, if they're long because they contain a long string, black won't break the string up (but I think that might be on black's to-do list).

One wouldn't run tox itself through pre-commit; one would instead directly run the lint commands that tox runs.

[yarikoptic]

ok, could we run the lint command we use for tox?