Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TF configuration for ImprovMX #211

Merged
merged 6 commits into from
Jan 29, 2025
Merged

Add TF configuration for ImprovMX #211

merged 6 commits into from
Jan 29, 2025

Conversation

waxlamp
Copy link
Member

@waxlamp waxlamp commented Jan 29, 2025

No description provided.

@waxlamp waxlamp requested a review from mvandenburgh January 29, 2025 16:35
@waxlamp waxlamp mentioned this pull request Jan 29, 2025
Merged
waxlamp
waxlamp commented Jan 29, 2025
View reviewed changes
Copy link
Member Author

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The run that is linked to this PR has a warning about the use of environment variables; I mistakenly included the ImprovMX API token as a "terraform" variable rather than "environment" but I've since fixed that and subsequent runs don't show that warning.

terraform/email_forwarding.tf Outdated Show resolved Hide resolved
terraform/main.tf Show resolved Hide resolved
mvandenburgh
mvandenburgh approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@mvandenburgh mvandenburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, including reverting 7ecdd07 if you'd like.

@waxlamp waxlamp merged commit a7fd7be into master Jan 29, 2025
2 checks passed
@waxlamp waxlamp deleted the improvmx branch January 29, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvandenburgh mvandenburgh mvandenburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waxlamp @mvandenburgh